Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-15470

Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB & Bytes

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      DatabaseDescriptor has several functions that convert between user supplied sizes in KB/MB and bytes. These are implemented without much consistency and, while unlikely, several have the potential to overflow since validation on the input is missing. Meanwhile, some widen the number to a long correctly. Options include: widening in all places or simply doing better validation on start up — currently only the lower bound of the valid range is checked for many of these fields.

      List of Affected DatabaseDescriptor Methods:

      • getColumnIndexSize
      • getColumnIndexCacheSize
      • getBatchSizeWarnThreshold
      • getNativeTransportFrameBlockSize
      • getRepairSessionSpaceInMegabytes
      • getNativeTransportMaxFrameSize

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mallika Mallika Kulkarni Assign to me
            jwest Jordan West
            Mallika Kulkarni
            Dinesh Joshi, Jordan West
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m

                Issue deployment