Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-15332

When repair is running with tracing, if a CorruptSSTableException is thrown while building Merkle Trees the DiskFailurePolicy does not get applied

    XMLWordPrintableJSON

    Details

    • Bug Category:
      Degradation - Other Exception
    • Severity:
      Normal
    • Complexity:
      Low Hanging Fruit
    • Discovered By:
      Unit Test
    • Platform:
      All
    • Impacts:
      None
    • Since Version:
    • Test and Documentation Plan:
      Hide
      branch diff tests pr
      branch diff tests pr

      Changes:

      1) JVMStabilityInspector checks for corruption or FSError and delegates to FileUtils for handling

      2) FileUtils now implements the die behavior

      3) JVMStabilityInspector now walks suppressed exceptions as well as the caused exception (edge case not in streaming where the second exception is fserror or corruption, so just added since saw suppression was common)

      4) dtest updated to keep track of the number of kill attempts (though does not kill, mostly so tests can reuse the cluster)

      Test case added which causes a corruption exception to be thrown from a SSTable during validation and shows that the handling makes its way to JVMStabilities kill instance method.

      Show
      branch diff tests pr branch diff tests pr Changes: 1) JVMStabilityInspector checks for corruption or FSError and delegates to FileUtils for handling 2) FileUtils now implements the die behavior 3) JVMStabilityInspector now walks suppressed exceptions as well as the caused exception (edge case not in streaming where the second exception is fserror or corruption, so just added since saw suppression was common) 4) dtest updated to keep track of the number of kill attempts (though does not kill, mostly so tests can reuse the cluster) Test case added which causes a corruption exception to be thrown from a SSTable during validation and shows that the handling makes its way to JVMStabilities kill instance method.

      Description

      When a repair is in the validation phase and is building MerkleTrees, if a corrupt SSTable exception is thrown the disk failure policy does not get applied

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dcapwell David Capwell
                Reporter:
                dcapwell David Capwell
                Authors:
                David Capwell
                Reviewers:
                Jordan West, Marcus Eriksson
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 50m
                  1h 50m