[CASSANDRA-15297] nodetool can not create snapshot with snapshot name that have special character

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.4, 4.1-alpha1, 4.1
• Component/s: Tool/nodetool
• Labels: pull-request-available
• Bug Category: Correctness - Unrecoverable Corruption / Loss
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 3.0.0

Source Control Link

https://github.com/apache/cassandra/commit/e773bbd9c6c52a2fedc127cb7ab77a1fdbeb63d2

Test and Documentation Plan

for this is just filter the special charter ,so we do normal test with snapshot and snapshot with special charter in snapshot name and got the result we need

• Assignee: Saranya Krishnakumar
• Reporter: Maxwell Guo

Authors

Saranya Krishnakumar

Reviewers

Benjamin Lerer, Chris Lohfink, Stefan Miklosovic

• Created: 02/Sep/19 08:45
• Updated: 27/May/22 19:24
• Resolved: 18/Mar/22 14:17

Description

we make snapshot through "nodetool snapshot -t snapshotname " , when snapshotname contains special characters like "/", the make snapshot process successfully , but the result
can be different ,when we check the data file directory or use "nodetool listsnapshots".
here is some case :

1. nodetool snapshot -t "p/s"
the listsnapshot resturns snapshot p for all table but actually the snapshot name is "p/s";
also the data directory is like the format : datapath/snapshots/p/s/snapshot-datafile-link


2. nodetool snapshot -t "/"
the listsnapshot resturns "there is not snapshot"; but the make snapshot process return successfully and the data directory is like the format : datapath/snapshots/snapshot-datafile-link

the Attachements are the result under our environment.

so for me , we suggest that the snapshot name should not contains special character. just throw exception and told the user not to use special character.

Issue Links

• links to: GitHub Pull Request #352