[CASSANDRA-15210] Streaming with CDC does not honor cdc_enabled

• Type: Bug
• Status: In Progress
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 3.11.x, 4.0.x, 5.x
• Component/s: Consistency/Streaming, Feature/Change Data Capture
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All

Test and Documentation Plan

See cci and dtest output

• Assignee: Andrew Prudhomme
• Reporter: Andrew Prudhomme

Authors

Andrew Prudhomme

• Created: 15/Jul/19 22:44
• Updated: 07/Mar/23 10:53

Description

When SSTables are streamed for a CDC enabled table, the updates are processed through the write path to ensure they are made available through the commit log. However, currently only the CDC state of the table is checked. Since CDC is enabled at both the node and table level, a node with CDC disabled (with cdc_enabled: false) will unnecessarily send updates through the write path if CDC is enabled on the table. This seems like an oversight.

I'd imagine the fix would be something like

 

-   hasCDC = cfs.metadata.params.cdc;
+   hasCDC = cfs.metadata.params.cdc && DatabaseDescriptor.isCDCEnabled();

in

org.apache.cassandra.db.streaming.CassandraStreamReceiver (4)

org.apache.cassandra.streaming.StreamReceiveTask (3.11)