[CASSANDRA-15203] Fix AlterTableStatement dropped type validation order

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Cluster/Schema
• Bug Category: Correctness - Recoverable Corruption / Loss
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0

Source Control Link

08b2192da0eb6deddcd8f79cd180d069442223ae

Test and Documentation Plan

N/A

• Assignee: Aleksey Yeschenko
• Reporter: Aleksey Yeschenko

Authors

Aleksey Yeschenko

Reviewers

Sam Tunnicliffe

• Created: 09/Jul/19 16:04
• Updated: 15/May/20 07:59
• Resolved: 10/Jul/19 13:53

Description

4.0 has a minor bug in AlterTableStatement, in which we compare value compatibility of dropped type with new type instead of the other way around (and order is significant here).
This results in more conversions identified as valid than should be allowed to.

The fix is a trivial one-liner.

Relatedly, we should audit all implementations of isValueCompatible() out there - at least one, BytesType - is no longer valid in 3.0+, since BytesType can no longer correctly read any complex column. And perhaps go even further, and restrict column recreation to only previously dropped type precisely, for which I have a couple arguments as well.

That said, I'd like to defer those to a different ticket.