[CASSANDRA-15033] Refactor to singleQuote reuse java.util.regex.Pattern instead of String.replaceAll for TableCQLHelper.java

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: CQL/Interpreter
• Assignee: DaeMyung Kang
• Reporter: DaeMyung Kang

Authors

DaeMyung Kang

• Created: 24/Feb/19 04:31
• Updated: 15/May/20 08:05
• Resolved: 08/Mar/19 09:10

Description

singleQuote uses `String.replaceAll ()` a lot in loop.

and 'String.replaceAll()' compiles the regular expression each time it is called.

 

public String replaceAll(String regex, String replacement) {
    return Pattern.compile(regex).matcher(this).replaceAll(replacement);
 }

 

It is suggested in javadoc (https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html#matches(java.lang.String,%20java.lang.CharSequence)) that it is efficient to reuse the pattern.