[CASSANDRA-14920] Some comparisons used for verifying paging queries in dtests only test the column names and not values

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Component/s: Test/dtest/python
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Assignee: Ariel Weisberg
• Reporter: Sam Tunnicliffe

Authors

Ariel Weisberg

• Created: 04/Dec/18 10:31
• Updated: 02/Aug/19 03:10
• Resolved: 15/Jan/19 21:35

Description

The implementation of PageAssertionMixin::assertEqualIgnoreOrder introduced in CASSANDRA-14134 can't be used to compare expected and actual results when the row data is represented by a dict. The underlying list_to_hashed_dict function expected lists of values and when it encounters a dict, it constructs its normalized list using only the keys. So the actual result values may be completely wrong, but as long as the field names are the same the equality check will pass. This affects only paging_tests.py and upgrade_tests/paging_test.py, and looks like it maybe a leftover from an earlier dev iteration, as some tests in the affected fixtures are already using the alternative (and correct) assertions.py::assert_lists_equal_ignoring_order.

Issue Links

• relates to: CASSANDRA-14421 Reenable upgrade tests