[CASSANDRA-14871] Severe concurrency issues in STCS,DTCS,TWCS,TMD.Topology,TypeParser

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 3.0.18, 3.11.4, 4.0-alpha1, 4.0
• Component/s: Legacy/Core, Local/Compaction
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Critical
• Complexity: Challenging
• Discovered By: User Report
• Since Version: 3.0.0
• Assignee: Robert Stupp
• Reporter: Robert Stupp

Authors

Robert Stupp

Reviewers

Blake Eggleston

• Created: 07/Nov/18 08:37
• Updated: 15/May/20 07:59
• Resolved: 01/Feb/19 11:35

Description

   There are a couple of places in the code base that do not respect that j.u.HashMap + related classes are not thread safe and some parts rely on internals of the implementation of HM, which can change.

We have observed failures like NullPointerException and  ConcurrentModificationException as well as wrong behavior.

Affected areas in the code base:

• SizeTieredCompactionStrategy
• DateTieredCompactionStrategy
• TimeWindowCompactionStrategy
• TokenMetadata.Topology
• TypeParser
• streaming / concurrent access to LifecycleTransaction (handled in CASSANDRA-14554)

While the patches for the compaction strategies + TypeParser are pretty straight forward, the patch for TokenMetadata.Topology requires it to be made immutable.