[CASSANDRA-14862] Fix incorrect sorting of replicas in SimpleStrategy.calculateNaturalReplicas

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Cluster/Membership, Consistency/Coordination
• Labels: 4.0-QA
• Severity: Low
• Assignee: Joey Lynch
• Reporter: Joey Lynch

Authors

Joey Lynch

Reviewers

Benedict Elliott Smith

• Created: 01/Nov/18 03:49
• Updated: 15/May/20 08:03
• Resolved: 08/Nov/18 02:47

Description

The sorting of natural replicas in SimpleStrategy.calculateNaturalReplicas committed as part of e645b917 for CASSANDRA-14726 has broken the TestTopology.test_size_estimates_multidc dtest (example run) as the "primary" ranges have now changed. I'm actually surprised only a single dtest fails as I believe we've broken multi-dc SimpleStrategy reasonably badly.

In particular the SimpleStrategy.calculateNaturalReplicas method cannot sort the endpoints by datacenter first. It has to leave them in the order that it found them else change which replicas are considered "primary" replicas (which mostly impacts repair and size estimates and the such).

I have written a regression unit test for the SimpleStrategy and am running it through circleci now. Will post the patch shortly.