[CASSANDRA-14822] Cassandra 4.0 doesn't output DESCRIBE TABLE representations that are valid

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Won't Fix
• Component/s: Legacy/Tools
• Labels: cqlsh
• Severity: Low
• Assignee: Joey Lynch
• Reporter: Joey Lynch

Authors

Joey Lynch

Reviewers

Jordan West

• Created: 12/Oct/18 18:49
• Updated: 30/Mar/21 18:46
• Resolved: 30/Mar/21 18:46

Description

Looks like right now on 4.0 the DESCRIBE output of a table is no longer valid since dclocal_read_repair_chance was removed:

cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy', 'replication_factor': 1};
cqlsh> CREATE TABLE test.test (key text, value text, PRIMARY KEY(key));
cqlsh> DESCRIBE TABLE test.test 

CREATE TABLE test.test (
    key text PRIMARY KEY,
    value text
) WITH bloom_filter_fp_chance = 0.01
    AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
    AND comment = ''
    AND compaction = {'class': 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', 'max_threshold': '32', 'min_threshold': '4'}
    AND compression = {'chunk_length_in_kb': '64', 'class': 'org.apache.cassandra.io.compress.LZ4Compressor'}
    AND crc_check_chance = 1.0
    AND dclocal_read_repair_chance = 0.0
    AND default_time_to_live = 0
    AND gc_grace_seconds = 864000
    AND max_index_interval = 2048
    AND memtable_flush_period_in_ms = 0
    AND min_index_interval = 128
    AND read_repair_chance = 0.0
    AND speculative_retry = '99p';

If you then try to copy and past that output it fails:

cqlsh> CREATE TABLE test.test2 (
   ...     key text PRIMARY KEY,
   ...     value text
   ... ) WITH bloom_filter_fp_chance = 0.01
   ...     AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
   ...     AND comment = ''
   ...     AND compaction = {'class': 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', 'max_threshold': '32', 'min_threshold': '4'}
   ...     AND compression = {'chunk_length_in_kb': '64', 'class': 'org.apache.cassandra.io.compress.LZ4Compressor'}
   ...     AND crc_check_chance = 1.0
   ...     AND dclocal_read_repair_chance = 0.0
   ...     AND default_time_to_live = 0
   ...     AND gc_grace_seconds = 864000
   ...     AND max_index_interval = 2048
   ...     AND memtable_flush_period_in_ms = 0
   ...     AND min_index_interval = 128
   ...     AND read_repair_chance = 0.0
   ...     AND speculative_retry = '99p';
SyntaxException: Unknown property 'dclocal_read_repair_chance'

Currently we leave in dclocal_read_repair_chance and read_repair_chance for the drivers per the comments left during CASSANDRA-13910.

I think we can just ignore those parameters in the validation/creation.

Issue Links

• relates to: CASSANDRA-13910 Remove read_repair_chance/dclocal_read_repair_chance