[CASSANDRA-14772] Fix issues in audit / full query log interactions

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Legacy/CQL, Legacy/Tools
• Severity: Normal
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/5242f7d4306f034f32e26834df06ff7fc85a3c16

Test and Documentation Plan

unit tests + existing dtests

• Assignee: Marcus Eriksson Assign to me
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Aleksey Yeschenko, Per Otterström

• Created: 21/Sep/18 08:26
• Updated: 21/Dec/20 08:08
• Resolved: 16/Apr/20 12:21

Description

There are some problems with the audit + full query log code that need to be resolved before 4.0 is released:

• Fix performance regression in FQL that makes it less usable than it should be.
• move full query log specific code to a separate package
• do some audit log class renames (I keep reading BinLogAuditLogger vs BinAuditLogger wrong for example)
• avoid parsing the CQL queries twice in QueryMessage when audit log is enabled.
• add a new tool to dump audit logs (ie, let fqltool be full query log specific). fqltool crashes when pointed to them.

Issue Links

• depends upon: CASSANDRA-14885 Add a new tool to dump audit logs