[CASSANDRA-14752] serializers/BooleanSerializer.java is using static bytebuffers which may cause problem for subsequent operations

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.27, 3.11.13, 4.0.4, 4.1-alpha1, 4.1
• Component/s: Legacy/Core
• Severity: Normal
• Since Version: 3.0.26

Source Control Link

https://github.com/apache/cassandra/commit/fb66800a00aeaa8046cb3e6b1401fdc4f81848d5

Test and Documentation Plan

 3.11 CircleCI

4.0 j8, j11

trunk j8, j11

 

New test from Marcus also added

• Assignee: Ekaterina Dimitrova
• Reporter: Varun Barala

Authors

Marcus Eriksson, Stefania Alborghetti

Reviewers

Benjamin Lerer, Ekaterina Dimitrova, Marcus Eriksson

• Created: 14/Sep/18 07:50
• Updated: 07/Mar/23 11:52
• Resolved: 17/Apr/22 18:51

Description

https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/serializers/BooleanSerializer.java#L26 It has two static Bytebuffer variables:-

private static final ByteBuffer TRUE = ByteBuffer.wrap(new byte[]{1});
private static final ByteBuffer FALSE = ByteBuffer.wrap(new byte[]{0});

What will happen if the position of these Bytebuffers is being changed by some other operations? It'll affect other subsequent operations. IMO Using static is not a good idea here.

A potential place where it can become problematic: https://github.com/apache/cassandra/blob/cassandra-2.1.13/src/java/org/apache/cassandra/db/marshal/AbstractCompositeType.java#L243 Since we are calling `.remaining()` It may give wrong results i.e 0 if these Bytebuffers have been used previously.

Solution:
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/serializers/BooleanSerializer.java#L42 Every time we return new bytebuffer object. Please do let me know If there is a better way. I'd like to contribute. Thanks!!

public ByteBuffer serialize(Boolean value)
{
return (value == null) ? ByteBufferUtil.EMPTY_BYTE_BUFFER
: value ? ByteBuffer.wrap(new byte[] {1}) : ByteBuffer.wrap(new byte[] {0}); // false
}

Issue Links

• blocks: CASSANDRA-16310 Track top partitions (by size and tombstone count) and display in nodetool tablestats