[CASSANDRA-14657] Handle failures in upgradesstables/cleanup/relocate

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.18, 3.11.4, 4.0-alpha1, 4.0
• Component/s: Local/SSTable
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Challenging
• Discovered By: Adhoc Test
• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Benedict Elliott Smith

• Created: 20/Aug/18 16:29
• Updated: 15/May/20 08:05
• Resolved: 14/Sep/18 06:46

Description

If a compaction in parallelAllSSTableOperation throws exception, all current transactions are closed, this can make us close a transaction that has not yet finished (since we can run many of these compactions in parallel). This causes this error:

java.lang.IllegalStateException: Cannot prepare to commit unless IN_PROGRESS; state is ABORTED

and this can get the leveled manifest (if running LCS) in a bad state causing this error message:

Could not acquire references for compacting SSTables ...