Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.7 beta 2
    • Component/s: None
    • Labels:
      None

      Description

      Avro is:

      • Missing many of the authorization calls that Thrift makes
      • Doesn't clean up ThreadLocal state when a connection closes (accomplished in Thrift via the hacked up thrift.CustomTThreadPoolServer)
      • Doesn't have a login method (probably due to the last issue)

        Issue Links

          Activity

          Hide
          Stu Hood added a comment -

          Nick fixed the other issues mentioned on this ticket, so this patch applies our ThreadLocal cleanups to Avro via AVRO-649.

          Show
          Stu Hood added a comment - Nick fixed the other issues mentioned on this ticket, so this patch applies our ThreadLocal cleanups to Avro via AVRO-649 .
          Hide
          Stu Hood added a comment -

          Marking as 'patch available', because we can apply AVRO-649 earlier to our Avro build.

          Show
          Stu Hood added a comment - Marking as 'patch available', because we can apply AVRO-649 earlier to our Avro build.
          Hide
          Doug Cutting added a comment -

          I wonder if you could instead simply use Jetty's Server class directly. The only line of code you're really getting from Avro's HttpServer is:

           new Context(server, "/").addServlet(new ServletHolder(new ResponderServlet(responder)), "/*");
          

          So this wouldn't duplicate much, and it would keep Avro's HttpServer API Jetty-independent.

          Show
          Doug Cutting added a comment - I wonder if you could instead simply use Jetty's Server class directly. The only line of code you're really getting from Avro's HttpServer is: new Context(server, "/" ).addServlet( new ServletHolder( new ResponderServlet(responder)), "/*" ); So this wouldn't duplicate much, and it would keep Avro's HttpServer API Jetty-independent.
          Hide
          Stu Hood added a comment -

          As suggested, rather than relying on Avro supporting pluggable thread pools, this patch accesses Jetty directly to set up the server.

          Show
          Stu Hood added a comment - As suggested, rather than relying on Avro supporting pluggable thread pools, this patch accesses Jetty directly to set up the server.
          Hide
          Eric Evans added a comment -

          lgtm; committed.

          Show
          Eric Evans added a comment - lgtm; committed.

            People

            • Assignee:
              Stu Hood
              Reporter:
              Stu Hood
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development