[CASSANDRA-14083] Avoid invalidating disk boundaries unnecessarily

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.11.2, 4.0-alpha1, 4.0
• Assignee: Paulo Motta
• Reporter: Paulo Motta

Authors

Paulo Motta

Reviewers

Marcus Eriksson

• Created: 30/Nov/17 14:00
• Updated: 15/May/20 08:02
• Resolved: 26/Dec/17 12:55

Description

We currently invalidate disk boundaries whenever instantiating a new replication strategy, but this is done whenever updating keyspace settings.

Computing new boundaries is expensive and unnecessarily invalidating them will cause DiskBoundaries consumers to also invalidate their work unnecessarily. For instance, after CASSANDRA-13948 the CompactionStrategyManager will reload all compaction strategies when the boundaries are invalidated.

In this case, we should only invalidate the disk boundaries when the replication settings change to avoid doing unnecessary work.

Issue Links

• is related to: CASSANDRA-13948 Reload compaction strategies when JBOD disk boundary changes
• is related to: CASSANDRA-14084 Disks can be imbalanced during replace of same address when using JBOD