Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-14083

Avoid invalidating disk boundaries unnecessarily

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Fix Version/s: 3.11.2, 4.0, 4.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      We currently invalidate disk boundaries whenever instantiating a new replication strategy, but this is done whenever updating keyspace settings.

      Computing new boundaries is expensive and unnecessarily invalidating them will cause DiskBoundaries consumers to also invalidate their work unnecessarily. For instance, after CASSANDRA-13948 the CompactionStrategyManager will reload all compaction strategies when the boundaries are invalidated.

      In this case, we should only invalidate the disk boundaries when the replication settings change to avoid doing unnecessary work.

        Attachments

        1. 3.11-14083-testall.png
          9 kB
          Paulo Motta (Deprecated)
        2. 3.11-14083-dtest.png
          58 kB
          Paulo Motta (Deprecated)
        3. trunk-14083-dtest.png
          68 kB
          Paulo Motta (Deprecated)
        4. trunk-14083-testall.png
          56 kB
          Paulo Motta (Deprecated)

          Issue Links

            Activity

              People

              • Assignee:
                pauloricardomg Paulo Motta (Deprecated)
                Reporter:
                pauloricardomg Paulo Motta (Deprecated)
                Authors:
                Paulo Motta (Deprecated)
                Reviewers:
                Marcus Eriksson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: