[CASSANDRA-13978] dtest failure in cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance due to deprecation warning

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Implemented
• Component/s: Test/dtest/python
• Labels: dtest lhf low-hanging-fruit
• Assignee: Mahdi Mohammadinasab
• Reporter: Joel Knighton

Authors

Mahdi Mohammadinasab

• Created: 27/Oct/17 17:21
• Updated: 16/Apr/19 09:29
• Resolved: 24/Jul/18 15:24

Description

The dtest cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance fails on all branches with pep8 package version 1.7.1. The pep8 package has been deprecated and renamed pycodestyle.

======================================================================
FAIL: test_pep8_compliance (cqlsh_tests.cqlsh_tests.TestCqlsh)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jkni/projects/cassandra-dtest/tools/decorators.py", line 48, in wrapped
    f(obj)
  File "/home/jkni/projects/cassandra-dtest/cqlsh_tests/cqlsh_tests.py", line 68, in test_pep8_compliance
    self.assertEqual(len(stderr), 0, stderr)
AssertionError: /home/jkni/projects/cassandra-dtest/venv/lib/python2.7/site-packages/pep8.py:2124: UserWarning: 

pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.

$ pip install pycodestyle
$ pycodestyle ...

  '\n\n'

We should update this dependency from pep8 to pycodestyle. With this change, several new errors are thrown. I don't know if these are new checks that we should choose to ignore, false positives due to new behaviors, or false negatives that are now successfully caught. If they were previously false negatives, we'll need to fix these in cqlsh on some branches.