Cassandra
  1. Cassandra
  2. CASSANDRA-139

thrift API should use lists instead of colon-delimited strings to specify column path

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4
    • Component/s: Core
    • Labels:
      None
    1. 0005-fix-get_column_count.patch
      3 kB
      Jonathan Ellis
    2. 0004-missed-one-rename-column.column_name-column.name.patch
      12 kB
      Jonathan Ellis
    3. 0003-update-system-tests.patch
      23 kB
      Jonathan Ellis
    4. ASF.LICENSE.NOT.GRANTED--0002-use-ColumnPath-ColumnParent-etc.-structs-to-encapsul.txt
      169 kB
      Jonathan Ellis
    5. ASF.LICENSE.NOT.GRANTED--0001-CASSANDRA-139-thrift-changes.txt
      405 kB
      Jonathan Ellis
    6. 0001-thrift-changes.patch
      7 kB
      Jonathan Ellis
    7. 0001-thrift-changes.patch
      5 kB
      Jonathan Ellis

      Issue Links

        Activity

        Jonathan Ellis created issue -
        Jonathan Ellis made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Minor [ 4 ]
        Jonathan Ellis made changes -
        Fix Version/s 0.4 [ 12313862 ]
        Jonathan Ellis made changes -
        Link This issue blocks CASSANDRA-185 [ CASSANDRA-185 ]
        Jonathan Ellis made changes -
        Assignee Jonathan Ellis [ jbellis ]
        Jonathan Ellis made changes -
        Attachment 0001-thrift-changes.patch [ 12412756 ]
        Jonathan Ellis made changes -
        Attachment 0001-thrift-changes.patch [ 12413057 ]
        Jonathan Ellis made changes -
        Jonathan Ellis made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jonathan Ellis made changes -
        Attachment 0003-update-system-tests.patch [ 12413218 ]
        Jonathan Ellis made changes -
        Sandeep Tata made changes -
        Link This issue blocks CASSANDRA-234 [ CASSANDRA-234 ]
        Jonathan Ellis made changes -
        Attachment 0005-fix-get_column_count.patch [ 12413518 ]
        Evan Weaver made changes -
        Comment [ Build fails with that patch:

        build-project:
             [echo] apache-cassandra-incubating: /Volumes/Projects/incubator/cassandra/trunk/build.xml
            [javac] Compiling 303 source files to /Volumes/Projects/incubator/cassandra/trunk/build/classes
            [javac] /Volumes/Projects/incubator/cassandra/trunk/src/java/org/apache/cassandra/db/ColumnReadCommand.java:33: cannot find symbol
            [javac] symbol : variable CMD_TYPE_GET_COLUMN
            [javac] location: class org.apache.cassandra.db.ColumnReadCommand
            [javac] super(table, key, CMD_TYPE_GET_COLUMN);
            [javac] ^
            [javac] /Volumes/Projects/incubator/cassandra/trunk/src/java/org/apache/cassandra/db/ColumnReadCommand.java:58: cannot find symbol
            [javac] symbol : method getRow(java.lang.String,java.lang.String,java.util.TreeSet<java.lang.String>)
            [javac] location: class org.apache.cassandra.db.Table
            [javac] return table.getRow(key, values[0], new TreeSet<String>(Arrays.asList(values[1])));
            [javac] ^
            [javac] /Volumes/Projects/incubator/cassandra/trunk/src/java/org/apache/cassandra/db/ColumnReadCommand.java:61: cannot find symbol
            [javac] symbol : method getRow(java.lang.String,java.lang.String,java.util.TreeSet<java.lang.String>)
            [javac] location: class org.apache.cassandra.db.Table
            [javac] return table.getRow(key, values[0] + ":" + values[1], new TreeSet<String>(Arrays.asList(values[2])));
            [javac] ^
            [javac] /Volumes/Projects/incubator/cassandra/trunk/src/java/org/apache/cassandra/test/DBTest.java:43: cannot find symbol
            [javac] symbol : method add(java.lang.String,byte[],int)
            [javac] location: class org.apache.cassandra.db.RowMutation
            [javac] rm.add("Test:" + "Column", value.getBytes(), i);
            [javac] ^
            [javac] /Volumes/Projects/incubator/cassandra/trunk/src/java/org/apache/cassandra/test/TestRunner.java:64: cannot find symbol
            [javac] symbol : method add(java.lang.String,byte[],int)
            [javac] location: class org.apache.cassandra.db.RowMutation
            [javac] rm.add("MailboxMailData0:SuperColumn-" + j + ":Column-" + k, bytes, k);
            [javac] ^
            [javac] /Volumes/Projects/incubator/cassandra/trunk/src/java/org/apache/cassandra/test/TestRunner.java:88: cannot find symbol
            [javac] symbol : method getRow(java.lang.String,java.lang.String,java.util.TreeSet<java.lang.String>)
            [javac] location: class org.apache.cassandra.db.Table
            [javac] Row row = table.getRow("0", "MailboxMailData0", list);
            [javac] ^
            [javac] Note: Some input files use or override a deprecated API.
            [javac] Note: Recompile with -Xlint:deprecation for details.
            [javac] Note: Some input files use unchecked or unsafe operations.
            [javac] Note: Recompile with -Xlint:unchecked for details.
            [javac] 6 errors
        ]
        Jonathan Ellis made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jonathan Ellis made changes -
        Fix Version/s 0.4 [ 12313862 ]
        Michael Greene made changes -
        Component/s Core [ 12312978 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12462706 ] patch-available, re-open possible [ 12751894 ]
        Gavin made changes -
        Workflow patch-available, re-open possible [ 12751894 ] reopen-resolved, no closed status, patch-avail, testing [ 12755098 ]

          People

          • Assignee:
            Jonathan Ellis
            Reporter:
            Jonathan Ellis
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development