[CASSANDRA-13443] V5 protocol flags decoding broken

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.11.0, 4.0-alpha1, 4.0
• Severity: Low
• Assignee: Robert Stupp
• Reporter: Robert Stupp

Authors

Robert Stupp

Reviewers

Stefania Alborghetti

• Created: 13/Apr/17 07:06
• Updated: 15/May/20 08:02
• Resolved: 13/Apr/17 09:24

Description

Since native protocol version 5 we deserialize the flags in org.apache.cassandra.cql3.QueryOptions.Codec#decode as follows:

            EnumSet<Flag> flags = Flag.deserialize(version.isGreaterOrEqualTo(ProtocolVersion.V5)
                                                   ? (int)body.readUnsignedInt()
                                                   : (int)body.readByte());

This works until the highest bit (0x80) is not used. readByte must be changed to readUnsignedByte.