Low Description
There are a number of instances where it appears the programmer intended to print a stack trace in an error message, but it is not actually being printed. For example, in BlacklistedDirectories.java:54:
catch (Exception e)
{
JVMStabilityInspector.inspectThrowable(e);
logger.error("error registering MBean {}", MBEAN_NAME, e);
//Allow the server to start even if the bean can't be registered
}
The logger will use the second argument for the braces, but will ignore the exception e. It would be helpful to have the stack traces of these exceptions printed. I propose adding a second line that prints the full stack trace: logger.error(e.getMessage(), e);
On the 2.1 branch, I found 8 instances of these types of messages:
db/BlacklistedDirectories.java:54: logger.error("error registering MBean {}", MBEAN_NAME, e);
io/sstable/SSTableReader.java:512: logger.error("Corrupt sstable {}; skipped", descriptor, e);
net/OutboundTcpConnection.java:228: logger.error("error processing a message intended for {}", poolReference.endPoint(), e);
net/OutboundTcpConnection.java:314: logger.error("error writing to {}", poolReference.endPoint(), e);
service/CassandraDaemon.java:231: logger.error("Exception in thread {}", t, e);
service/CassandraDaemon.java:562: logger.error("error registering MBean {}", MBEAN_NAME, e);
streaming/StreamSession.java:512: logger.error("[Stream #{}] Streaming error occurred", planId(), e);
transport/Server.java:442: logger.error("Problem retrieving RPC address for {}", endpoint, e);
And one where it'll print the toString() version of the exception:
db/Directories.java:689: logger.error("Could not calculate the size of {}. {}", input, e);
I'm happy to create a patch for each branch, just need a little guidance on how to do so. We're currently running 2.1 so I started there.