[CASSANDRA-13357] A possible NPE in nodetool getendpoints

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Won't Fix
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Tool/nodetool
• Severity: Normal
• Assignee: Hao Zhong
• Reporter: Hao Zhong

Authors

Hao Zhong

Reviewers

Eduard Tudenhoefner, Michael Semb Wever

• Created: 21/Mar/17 05:13
• Updated: 16/Dec/22 21:56
• Resolved: 03/Apr/19 10:31

Description

The GetEndpoints.execute method has the following code:

GetEndpoints.java

       List<InetAddress> endpoints = probe.getEndpoints(ks, table, key);
        for (InetAddress endpoint : endpoints)
        {
            System.out.println(endpoint.getHostAddress());
        }

This code can throw NPE. A similar bug is fixed in CASSANDRA-8950. The buggy code is

NodeCmd.java

  List<InetAddress> endpoints = this.probe.getEndpoints(keySpace, cf, key);

        for (InetAddress anEndpoint : endpoints)
        {
           output.println(anEndpoint.getHostAddress());
        }

The fixed code is:

NodeCmd.java

try
        {
            List<InetAddress> endpoints = probe.getEndpoints(keySpace, cf, key);
            for (InetAddress anEndpoint : endpoints)
               output.println(anEndpoint.getHostAddress());
        }
        catch (IllegalArgumentException ex)
        {
            output.println(ex.getMessage());
            probe.failed();
        }

The GetEndpoints.execute method shall be modified as CASSANDRA-8950 does.