Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-13297

Cleanup naming around native transport version parsing

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Normal
    • Resolution: Unresolved
    • None
    • Legacy/CQL
    • None

    Description

      While jasobrown and myself were chasing down how features and versions are parsed in the binary protocol, it took us a while to realize that the following check in StartupMessage that creates a CassandraVersion object is actually parsing the CQL Version (but again.. with a class named CassandraVersion...)

      if (new CassandraVersion(cqlVersion).compareTo(new CassandraVersion("2.99.0")) < 0)
      

      It then turns out there is already a CqlVersion class that has some of what we want but only appears to be being used by Stress.

      This isn't very clear so renaming the classes to make it obvious that we're parsing a CQL Language version vs. the Cassandra Server version vs. the Binary Native Protocol version will make this situation slightly better for people trying to contribute to the codebase.

      Attachments

        Activity

          People

            Unassigned Unassigned
            mkjellman Michael Kjellman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: