[CASSANDRA-13282] Commitlog replay may fail if last mutation is within 4 bytes of end of segment

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.10, 3.0.13, 3.11.0, 4.0-alpha1, 4.0
• Component/s: Legacy/Core
• Bug Category: Availability - Unavailable
• Severity: Normal
• Assignee: Jeff Jirsa Assign to me
• Reporter: Jeff Jirsa

Authors

Jeff Jirsa

Reviewers

Branimir Lambov

• Created: 01/Mar/17 05:02
• Updated: 15/May/20 08:06
• Resolved: 13/Mar/17 05:01

Description

Following CASSANDRA-9749 , stricter correctness checks on commitlog replay can incorrectly detect "corrupt segments" and stop commitlog replay (and potentially stop cassandra, depending on the configured policy). In CommitlogReplayer#replaySyncSection we try to read a 4 byte int serializedSize, and if it's 0 (which will happen due to zeroing when the segment was created), we continue on to the next segment. However, it appears that if a mutation is sized such that it ends with 1, 2, or 3 bytes remaining in the segment, we'll pass the isEOF on the while loop but fail to read the serializedSize int, and fail.