[CASSANDRA-13082] Suspect OnDiskIndex.IteratorOrder.startAt code for ASC

• Type: Bug
• Status: Open
• Priority: Low
• Resolution: Unresolved
• Fix Version/s: 5.x
• Component/s: Legacy/Local Write-Read Paths
• Severity: Low
• Assignee: Unassigned
• Reporter: David Brosius
• Created: 28/Dec/16 20:24
• Updated: 07/Mar/23 10:54

Description

startAt for ASC does

                case ASC:
                    if (found.cmp < 0) // search term was bigger then whole data set
                        return found.index;
                    return inclusive && (found.cmp == 0 || found.cmp < 0) ? found.index : found.index - 1;

which is equivalent to

                case ASC:
                    if (found.cmp < 0) // search term was bigger then whole data set
                        return found.index;
                    return inclusive ? found.index : found.index - 1;

which seems wrong. Is the parenthesis wrong here?