Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 4.0
    • Component/s: None
    • Labels:
      None

      Description

      Compaction stats is missing some useful metrics.

      • Number of sstables dropped out of compaction due to disk space
      • Number of compactions that had to drop sstables
      • Compactions aborted (due to reduced scope failure)

      There will be more, I'll edit the description with the list as I figure it out.

        Issue Links

          Activity

          Hide
          jasobrown Jason Brown added a comment -

          committed as sha 52df6a58d18200c11d2e9d88fc9276b5ef1ee06a to 4.0. thanks!

          Show
          jasobrown Jason Brown added a comment - committed as sha 52df6a58d18200c11d2e9d88fc9276b5ef1ee06a to 4.0. thanks!
          Hide
          rustyrazorblade Jon Haddad added a comment -

          No objections here, thanks for the review!

          Show
          rustyrazorblade Jon Haddad added a comment - No objections here, thanks for the review!
          Hide
          jasobrown Jason Brown added a comment -

          On the whole, this looks fine. I renamed the functions starting with inc to increment, and cleaned up some formatting. If you are good with that, and tests pass, I'll +1 and commit.

          trunk
          branch
          dtest
          testall
          Show
          jasobrown Jason Brown added a comment - On the whole, this looks fine. I renamed the functions starting with inc to increment , and cleaned up some formatting. If you are good with that, and tests pass, I'll +1 and commit. trunk branch dtest testall
          Show
          rustyrazorblade Jon Haddad added a comment - https://github.com/apache/cassandra/compare/trunk...rustyrazorblade:13015_trunk.patch
          Hide
          rustyrazorblade Jon Haddad added a comment - - edited

          Once CASSANDRA-12979 is merged I'll knock this out.

          Show
          rustyrazorblade Jon Haddad added a comment - - edited Once CASSANDRA-12979 is merged I'll knock this out.

            People

            • Assignee:
              rustyrazorblade Jon Haddad
              Reporter:
              rustyrazorblade Jon Haddad
              Reviewer:
              Jason Brown
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development