[CASSANDRA-12953] Index name uniqueness validation in CFMetaData is not entirely correct

• Type: Bug
• Status: In Progress
• Priority: Low
• Resolution: Unresolved
• Fix Version/s: 3.0.x, 3.11.x
• Component/s: Legacy/Distributed Metadata
• Severity: Low
• Assignee: Unassigned
• Reporter: Aleksey Yeschenko
• Created: 24/Nov/16 15:38
• Updated: 16/Apr/19 09:30

Description

The check in CFMetaData.validate() relies on external global state (Schema.instance to fetch all index names in the keyspace. However, in many cases the validation will be performed without all table instances registered in Schema.isntance yet. The check should live in KeyspaceMetadata instead, where no such access is required.

Things broken by it right now: multiple tests, and Thrift's system_add_keyspace, at least.