[CASSANDRA-12937] Default setting (yaml) for SSTable compression

• Type: Improvement
• Status: Open
• Priority: Low
• Resolution: Unresolved
• Fix Version/s: 5.x
• Component/s: Local/Config
• Labels: AdventCalendar2021
• Complexity: Normal

Test and Documentation Plan

CI

• Assignee: Unassigned
• Reporter: Michael Semb Wever

Reviewers

Maxim Muzafarov, Michael Semb Wever, Stefan Miklosovic

• Created: 21/Nov/16 06:41
• Updated: 16/Sep/24 12:23

Description

In many situations the choice of compression for sstables is more relevant to the disks attached than to the schema and data.

This issue is to add to cassandra.yaml a default value for sstable compression that new tables will inherit (instead of the defaults found in CompressionParams.DEFAULT.

Examples where this can be relevant are filesystems that do on-the-fly compression (btrfs, zfs) or specific disk configurations or even specific C* versions (see CASSANDRA-10995 ).

Additional information for newcomers

Some new fields need to be added to cassandra.yaml to allow specifying the field required for defining the default compression parameters. In DatabaseDescriptor a new CompressionParams field should be added for the default compression. This field should be initialized in DatabaseDescriptor.applySimpleConfig(). At the different places where CompressionParams.DEFAULT was used the code should call DatabaseDescriptor#getDefaultCompressionParams that should return some copy of configured CompressionParams.
Some unit test using OverrideConfigurationLoader should be used to test that the table schema use the new default when a new table is created (see CreateTest for some example).

Issue Links

• is blocked by: CASSANDRA-19592 Expand CREATE TABLE CQL on a coordinating node before submitting to CMS
• is blocked by: CASSANDRA-19906 memtable configuration is order-dependent
• relates to: CASSANDRA-10995 Consider disabling sstable compression by default in 3.x
• links to: Claude's PR
• links to: GitHub Pull Request #3330
• links to: Stefan's squashed