[CASSANDRA-12681] Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Distributed Metadata

Source Control Link

https://github.com/apache/cassandra/commit/d45f323eb972c6fec146e5cfa84fdc47eb8aa5eb

• Assignee: Nachiket Patil
• Reporter: Nachiket Patil

Authors

Nachiket Patil

Reviewers

Jeff Jirsa

• Created: 21/Sep/16 22:54
• Updated: 13/Nov/24 22:17
• Resolved: 28/Sep/16 01:28

Description

Add some restrictions around create / alter keyspace with NetworkTopologyStrategy:
1. Do not accept empty replication configuration (no DC options after class). Cassandra checks that SimpleStrategy must have replication_factor option but does not check that at least one DC should be present in the options for NetworkTopologyStrategy.
2. Cassandra accepts any random string as DC name replication option for NetworkTopologyStrategy while creating or altering keyspaces. Add a restriction that the options specified is valid datacenter name. Using incorrect value or simple mistake in typing the DC name can cause outage in production environment.

Issue Links

• is duplicated by: CASSANDRA-9605 Error message when creating a KS replicated to a non-existent DC
• is duplicated by: CASSANDRA-13702 Error on keyspace create/alter if referencing non-existing DC in cluster
• is related to: CASSANDRA-14952 NPE when using allocate_tokens_for_keyspace and add new DC