[CASSANDRA-1265] make getBuckets deterministic

• Type: Sub-task
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.6.9, 0.7 beta 1
• Assignee: Tom Hobbs
• Reporter: Jonathan Ellis

Authors

Tom Hobbs

• Created: 10/Jul/10 03:43
• Updated: 16/Apr/19 09:33
• Resolved: 12/Jul/10 01:03

Description

CompactionManager.getBuckets is nondeterministic as explained in the parent issue.

This can be fixed either by sorting in getBuckets, or requiring that the iterable passed be sorted already. Either is fine.

We also need to add some unit tests to CompactionManagerTest for getBuckets. We need to decouple getBuckets a little to do this sanely; rather than examining sstable length directly or introducing some extra interface, let's declare getBuckets as

static Set<List<T>> getBuckets(Iterable<Pair<T, Integer>> files, long min)

where the integer in the pair is the file size. Then you can write tests against Strings instead of SSTableReaders.