Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 0.6.9, 0.7 beta 1
    • Component/s: None
    • Labels:
      None

      Description

      CompactionManager.getBuckets is nondeterministic as explained in the parent issue.

      This can be fixed either by sorting in getBuckets, or requiring that the iterable passed be sorted already. Either is fine.

      We also need to add some unit tests to CompactionManagerTest for getBuckets. We need to decouple getBuckets a little to do this sanely; rather than examining sstable length directly or introducing some extra interface, let's declare getBuckets as

      static Set<List<T>> getBuckets(Iterable<Pair<T, Integer>> files, long min)

      where the integer in the pair is the file size. Then you can write tests against Strings instead of SSTableReaders.

        Attachments

        1. cassandra-0.6-1265.txt
          8 kB
          Tyler Hobbs
        2. cassandra-0.6-1265.txt
          8 kB
          Tyler Hobbs

          Activity

            People

            • Assignee:
              thobbs Tyler Hobbs
              Reporter:
              jbellis Jonathan Ellis
              Authors:
              Tyler Hobbs
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: