[CASSANDRA-12331] Unreleased Resource: Sockets

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.9, 3.8
• Component/s: Legacy/Streaming and Messaging
• Labels: easyfix newbie patch
• Assignee: Arunkumar M
• Reporter: Eduardo Aguinaga

Authors

Arunkumar M

Reviewers

Yuki Morishita

• Created: 27/Jul/16 18:56
• Updated: 16/Apr/19 09:30
• Resolved: 11/Aug/16 16:07

Description

Overview:
In May through June of 2016 a static analysis was performed on version 3.0.5 of the Cassandra source code. The analysis included an automated analysis using HP Fortify v4.21 SCA and a manual analysis utilizing SciTools Understand v4. The results of that analysis includes the issue below.

Issue:
Sockets are low level resources that must be explicitly released so subsequent callers will have access to previously used sockets. In the file RMIServerSocketFactoryImpl.java on lines 15-16 a socket is acquired and eventually returned to the caller on line 18.

If an exception is thrown by the code on line 17 the socket acquired on lines 15-16 will not be released for subsequent reuse.

RMIServerSocketFactoryImpl.java, lines 13-19:

13 public ServerSocket createServerSocket(final int pPort) throws IOException
14 {
15     ServerSocket socket = ServerSocketFactory.getDefault()
16                                              .createServerSocket(pPort, 0, InetAddress.getLoopbackAddress());
17     socket.setReuseAddress(true);
18     return socket;
19 }