XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Platform independent implementation of DirectorySizeCalculator

      On linux, simplify to Arrays.stream(path.listFiles()).mapToLong(File::length).sum();

      Refactor DirectorySizeCalculator

      I don't get the DirectorySizeCalculator. Why the alive and visited sets, the listFiles step? Either list the files and just loop through them, or do the walkFileTree operation – you are now doing the same work twice. Use a plain long instead of the atomic as the class is still thread-unsafe.

      TolerateErrorsInSection should not depend on previous SyncSegment status in CommitLogReader

      tolerateErrorsInSection &=: I don't think it was intended for the value to depend on previous iterations.

      Refactor interface of SImpleCachedBufferPool

      SimpleCachedBufferPool should provide getThreadLocalReusableBuffer(int size) which should automatically reallocate if the available size is less, and not expose a setter at all.

      Change CDC exception to WriteFailureException instead of WriteTimeoutException
      Remove unused CommitLogTest.testRecovery(byte[] logData)
      NoSpamLogger a message when at CDC capacity

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                JoshuaMcKenzie Joshua McKenzie
                Reporter:
                JoshuaMcKenzie Joshua McKenzie
                Authors:
                Joshua McKenzie
                Reviewers:
                Branimir Lambov
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: