[CASSANDRA-11984] StorageService shutdown hook should use a volatile variable

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.7, 3.0.8, 3.8
• Component/s: Legacy/Core
• Severity: Normal
• Assignee: Edward Capriolo
• Reporter: Edward Capriolo

Authors

Edward Capriolo

Reviewers

Stefania Alborghetti

• Created: 09/Jun/16 01:32
• Updated: 16/Apr/19 09:30
• Resolved: 10/Jun/16 20:24

Description

In StorageService.java there is a variable accessed from other threads that is not marked volatile.

  private boolean inShutdownHook = false;
  public boolean isInShutdownHook()
   {
       return inShutdownHook;
   }
  drainOnShutdown = new Thread(new WrappedRunnable()
       {
           @Override
           public void runMayThrow() throws InterruptedException
           {
               inShutdownHook = true;

This is called from at least here:

./src/java/org/apache/cassandra/concurrent/DebuggableScheduledThreadPoolExecutor.java:                if (!StorageService.instance.isInShutdownHook())

This could cause issues in controlled shutdown like drain commands.