[CASSANDRA-11976] cqlsh tab completion doesn't work in 2.1

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Duplicate
• Component/s: Legacy/CQL
• Labels: cqlsh
• Severity: Low
• Assignee: Yusuke Takata
• Reporter: Yusuke Takata

Authors

Yusuke Takata

Reviewers

Tom Hobbs

• Created: 08/Jun/16 08:20
• Updated: 16/Apr/19 09:30
• Resolved: 23/Jun/16 20:55

Description

cqlsh tab completion doesn't work when there are two tables with the same prefix.
I found the similar completion issue at CASSANDRA-10733, but my problem is not fixed by the existing issue in 2.1.

cqlsh> CREATE KEYSPACE sample_ks WITH replication = {'class': 'SimpleStrategy' , 'replication_factor': 1 };
cqlsh> CREATE TABLE sample_ks.tbl_a ( key text PRIMARY KEY );
cqlsh> CREATE TABLE sample_ks.tbl_b ( key text PRIMARY KEY, value int );

// works correctly
cqlsh> INSERT INTO sample_ks.tb<TAB>
cqlsh> INSERT INTO sample_ks.tbl_

// fix required
cqlsh> INSERT INTO samp<TAB>
cqlsh> INSERT INTO sample_ks.tbl_( 

Also, completion doesn't work with a single column table.

cqlsh> CREATE KEYSPACE sample_ks WITH replication = {'class': 'SimpleStrategy' , 'replication_factor': 1 };
cqlsh> CREATE TABLE sample_ks.tbl_a ( key text PRIMARY KEY );
cqlsh> CREATE TABLE sample_ks.tbl_b ( key text PRIMARY KEY, value int );

// fix required (unnecessary comma)
cqlsh> INSERT INTO sample_ks.tbl_a<TAB>
cqlsh> INSERT INTO sample_ks.tbl_a (key,
// fix required (no reaction)
cqlsh> INSERT INTO sample_ks.tbl_a (key) VALU<TAB>
cqlsh> INSERT INTO sample_ks.tbl_a (key) VALU
// fix required (I can't insert only a key.)
cqlsh> INSERT INTO sample_ks.tbl_b<TAB>
cqlsh> INSERT INTO sample_ks.tbl_b (key, value

I fixed the completion problem in 2.1 branch. Could someone review the attached patch?