[CASSANDRA-11930] Range tombstone serialisation between 2.1 and 3.0 nodes (in 3.0 -> 2.1 direction) is broken for some Thrift deletions

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.7, 3.7
• Component/s: Legacy/Coordination
• Severity: Normal
• Assignee: Tom Hobbs
• Reporter: Aleksey Yeschenko

Authors

Tom Hobbs

Reviewers

Aleksey Yeschenko

• Created: 31/May/16 15:48
• Updated: 16/Apr/19 09:30
• Resolved: 05/Jun/16 23:34

Description

LegacyLayout.LegacyRangeTombstoneList::serialize() has a broken assumption that a range tombstone implies CompositeType. This is incorrect, as you can have non-CompositeType range tombstones created via Thrift in 2.1, and as such wrapping clusteringComparator.subtypes() in a CompositeType is incorrect. On 2.1/2.2 side, when decoding the range tombstone list, RangeTombstoneList::deserialize() will use the raw type to decode start and end bounds, which will end up being confused by the extra 2 bytes in the beginning (short length) plus end of component header in the end.

Issue Links

• is part of: CASSANDRA-11489 DynamicCompositeType failures during 2.1 to 3.0 upgrade.