[CASSANDRA-11742] Failed bootstrap results in exception when node is restarted

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.7, 3.0.7, 3.7
• Component/s: Local/Startup and Shutdown
• Severity: Low
• Since Version: 2.2.0
• Assignee: Joel Knighton Assign to me
• Reporter: Tommy Stendahl

Authors

Joel Knighton

Reviewers

Sam Tunnicliffe

• Created: 10/May/16 13:47
• Updated: 16/Apr/19 09:30
• Resolved: 03/Jun/16 10:02

Description

Since 2.2 a failed bootstrap results in a org.apache.cassandra.exceptions.ConfigurationException: Found system keyspace files, but they couldn't be loaded! exception when the node is restarted. This did not happen in 2.1, it just tried to bootstrap again. I know that the workaround is relatively easy, just delete the system keyspace in the data folder on disk and try again, but its a bit annoying that you have to do that.
The problem seems to be that the creation of the system.local table has been moved to just before the bootstrap begins (in 2.1 it was done much earlier) and as a result its still in the memtable och commitlog if the bootstrap failes. Still a few values is inserted to the system.local table at an earlier point in the startup and they have been flushed from the memtable to an sstable. When the node is restarted the SystemKeyspace.checkHealth() is executed before the commitlog is replayed and therefore only see the sstable with an incomplete system.local table and throws an exception.
I think we could fix this very easily by forceFlush the system keyspace in the StorageServiceShutdownHook, I have included a patch that does this.

Issue Links

• is duplicated by: CASSANDRA-11934 System keyspace corruption
• is duplicated by: CASSANDRA-11813 Bad first start leaves node in invalid state.