[CASSANDRA-1160] race with insufficiently constructed Gossiper

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.6.3, 0.7 beta 1
• Severity: Low
• Assignee: Matthew F. Dennis
• Reporter: Jonathan Ellis

Authors

Matthew F. Dennis

• Created: 04/Jun/10 13:59
• Updated: 16/Apr/19 09:33
• Resolved: 10/Jun/10 17:06

Description

Gossiper.start needs to be integrated into the constructor. Currently you can have threads using the gossiper instance before start finishes (or even starts?), resulting in tracebacks like this:

ERROR [GMFD:1] 2010-06-02 10:45:49,878 CassandraDaemon.java (line 78) Fatal exception in thread Thread[GMFD:1,5,main]
java.lang.AssertionError
at org.apache.cassandra.net.Header.<init>(Header.java:56)
at org.apache.cassandra.net.Header.<init>(Header.java:74)
at org.apache.cassandra.net.Message.<init>(Message.java:58)
at org.apache.cassandra.gms.Gossiper.makeGossipDigestAckMessage(Gossiper.java:294)
at org.apache.cassandra.gms.Gossiper$GossipDigestSynVerbHandler.doVerb(Gossiper.java:935)
at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:40)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
ERROR [GMFD:2] 2010-06-02 10:45:49,880 CassandraDaemon.java (line 78) Fatal exception in thread Thread[GMFD:2,5,main]
java.lang.AssertionError
at org.apache.cassandra.net.Header.<init>(Header.java:56)
at org.apache.cassandra.net.Header.<init>(Header.java:74)
at org.apache.cassandra.net.Message.<init>(Message.java:58)
at org.apache.cassandra.gms.Gossiper.makeGossipDigestAckMessage(Gossiper.java:294)
at org.apache.cassandra.gms.Gossiper$GossipDigestSynVerbHandler.doVerb(Gossiper.java:935)
at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:40)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)

Issue Links

• is duplicated by: CASSANDRA-1010 race condition with Gossiper with receiving messages when starting up?