[CASSANDRA-11551] Incorrect counting of pending messages in OutboundTcpConnection

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.13, 3.0.17, 3.11.3
• Severity: Low
• Assignee: Jaydeepkumar Chovatia
• Reporter: Robert Stupp

Authors

Jaydeepkumar Chovatia

Reviewers

Ariel Weisberg

• Created: 12/Apr/16 09:10
• Updated: 16/Apr/19 09:30
• Resolved: 16/May/18 21:40

Description

Somehow OutboundTcpConnection.getPendingMessages() seems to return a wrong number.

nodetool netstats
Mode: NORMAL
Not sending any streams.
Read Repair Statistics:
Attempted: 1655
Mismatch (Blocking): 0
Mismatch (Background): 2
Pool Name                    Active   Pending      Completed
Large messages                  n/a         5              0
Small messages                  n/a         0       31534100
Gossip messages                 n/a         0         520393

Inspection of the heap dump of that node unveiled that all instances of OutboundTcpConnection.backlog are empty but currentMsgBufferCount is 1 for 5 instances of OutboundTcpConnection.

Maybe the cause is in OutboundTcpConnection.run() where drainedMessages.size() is called twice but assumed that these are equal.

/cc aweisberg