[CASSANDRA-11450] Should not search for the index of a column if the table is not using secondaryIndex.

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.6
• Component/s: Local/Compaction
• Severity: Normal
• Assignee: Dikang Gu
• Reporter: Dikang Gu

Authors

Dikang Gu

Reviewers

Sam Tunnicliffe

• Created: 28/Mar/16 23:46
• Updated: 16/Apr/19 09:30
• Resolved: 29/Mar/16 12:02

Description

We are not using secondary index in our cluster, but when I profile the compaction, I find that ~5.5% of the compaction time is spent on this line of the code function LazilyCompactedRow.Reducer.reduce():

if (cell.isLive() && !container.getColumn(cell.name()).equals(cell))

before this line there is check to skip the look up, which seems to be not working:

// skip the index-update checks if there is no indexing needed since they are a bit expensive
if (indexer == SecondaryIndexManager.nullUpdater)
return;

My patch is to set the indexer to be nullUpdater if the table has no associated index.

Let me know if it's the right fix.