[CASSANDRA-11013] Stale entries not purged from CompositesIndex

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.3, 3.3
• Component/s: Legacy/Local Write-Read Paths
• Severity: Normal
• Assignee: Sam Tunnicliffe
• Reporter: Sam Tunnicliffe

Authors

Sam Tunnicliffe

Reviewers

Benedict Elliott Smith

• Created: 14/Jan/16 11:37
• Updated: 16/Apr/19 09:30
• Resolved: 14/Jan/16 14:17

Description

Since CASSANDRA-9975, the cleanup of stale index entries at read time has been broken for CompositesIndex instances (KeysIndex is not affected).
The issue is that the call to deleteAllEntries is made in the onClose method of the anonymous Transformation, where it should be in onPartitionClose. This wasn't caught by the existing unit test (o.a.c.db.SecondaryIndexTest::testDeleteOfInconsistentValuesInKeysIndex as it only checks that the stale entries are filtered from the returned results, not that they are actually purged from the index tables.