[CASSANDRA-10816] Explicitly handle SSL handshake errors during connect()

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.5, 3.0.3, 3.2
• Component/s: Legacy/Streaming and Messaging
• Severity: Normal
• Since Version: 2.0.3
• Assignee: Stefan Podkowinski
• Reporter: Stefan Podkowinski

Authors

Stefan Podkowinski

Reviewers

Ariel Weisberg

• Created: 04/Dec/15 13:23
• Updated: 16/Apr/19 09:30
• Resolved: 10/Dec/15 16:39

Description

Diagnosing internode SSL issues can be a problem as any messaging IOException before this patch is just logged to debug, which is likely not enabled in most cases. Logs will just show nothing in case of any problems with SSL certs.

Also the implemented retry semantics in OutboundTcpConnection will not make much sense for SSL handshake errors and will cause unnecessary load for both peers.

The proposed patch will explicitly catch SSLHandshakeException, log them to error and abort connect().

Issue Links

• is related to: CASSANDRA-6349 IOException in MessagingService.run() causes orphaned storage server socket
• links to: patch-2.1
• links to: patch-2.2
• links to: patch-3.0