[CASSANDRA-10749] DeletionTime.compareTo wrong in rare cases

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.1.12, 2.2.4, 3.0.1, 3.1
• Severity: Low
• Assignee: Robert Stupp
• Reporter: Robert Stupp

Authors

Robert Stupp

Reviewers

Sylvain Lebresne

• Created: 22/Nov/15 11:32
• Updated: 16/Apr/19 09:30
• Resolved: 27/Nov/15 08:32

Description

org.apache.cassandra.db.DeletionTime#compareTo looks like this:

    public int compareTo(DeletionTime dt)
    {
        if (markedForDeleteAt() < dt.markedForDeleteAt())
            return -1;
        else if (markedForDeleteAt() > dt.markedForDeleteAt())
            return 1;
        else if (localDeletionTime() < dt.localDeletionTime())
            return -1;
        else if (localDeletionTime() > dt.localDeletionTime())
            return -1;
        else
            return 0;
    }

I think that localDeletionTime() > dt.localDeletionTime() should return 1, but I'm not sure. /cc slebresne