Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.8 beta 1
    • Component/s: Core
    • Labels:
      None

      Description

      Break out the increment counters out of CASSANDRA-580. Classes are shared between the two features but without the plain version vector code the changeset becomes smaller and more manageable.

      1. Partitionedcountersdesigndoc.pdf
        170 kB
        Kelvin Kakugawa
      2. increment_test.py
        14 kB
        Kelvin Kakugawa
      3. CASSANDRA-1072.pre-value_refactor.patch
        253 kB
        Kelvin Kakugawa
      4. CASSANDRA-1072.121710.2.patch
        254 kB
        Kelvin Kakugawa

        Issue Links

          Activity

          Gavin made changes -
          Link This issue is depended upon by CASSANDRA-2101 [ CASSANDRA-2101 ]
          Gavin made changes -
          Link This issue blocks CASSANDRA-2101 [ CASSANDRA-2101 ]
          Gavin made changes -
          Workflow patch-available, re-open possible [ 12752245 ] reopen-resolved, no closed status, patch-avail, testing [ 12755257 ]
          Gavin made changes -
          Workflow no-reopen-closed, patch-avail [ 12510527 ] patch-available, re-open possible [ 12752245 ]
          ebullient12 made changes -
          Comment [ I am trying to implement counters. Does anyone has php client of increment_test.py or any help in this direction? ]
          Jonathan Ellis made changes -
          Reviewer jbellis slebresne
          Kelvin Kakugawa made changes -
          Link This issue blocks CASSANDRA-2101 [ CASSANDRA-2101 ]
          Johan Oskarsson made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Reviewer jbellis
          Fix Version/s 0.8 [ 12314820 ]
          Resolution Fixed [ 1 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.pre-value_refactor.patch [ 12466756 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121710.patch [ 12466493 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121710.2.patch [ 12466515 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121510.patch [ 12466350 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121710.patch [ 12466493 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121310.patch [ 12466181 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121510.patch [ 12466350 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12459752 ]
          Kelvin Kakugawa made changes -
          Comment [ I was looking through the code and thought about it more.

          We can't remove value ser/des, because we need to serialize it for the commit log (and hinted hand-off). So, value needs to be serialized, at some point. So, the disk format won't change.

          However, we can optimize the code to not recalculate the total on every update w/o read. Looking into this. ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.120710.patch [ 12465754 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.121310.patch [ 12466181 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.120610.patch [ 12465636 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.120710.patch [ 12465754 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.120110.patch [ 12465059 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.112210.patch [ 12460218 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.120610.patch [ 12465636 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.120110.patch [ 12465059 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072.112210.patch [ 12460218 ]
          Kelvin Kakugawa made changes -
          Attachment Partitionedcountersdesigndoc.pdf [ 12459754 ]
          Kelvin Kakugawa made changes -
          Attachment Incrementcountersdesigndoc.pdf [ 12450728 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12459752 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12458865 ]
          Kelvin Kakugawa made changes -
          Attachment increment_test.py [ 12459096 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12458865 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072-2.patch [ 12447563 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072-2.patch [ 12452360 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12454495 ]
          Jonathan Ellis made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12454495 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12451700 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12452626 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12452626 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072-2.patch [ 12452360 ]
          Kelvin Kakugawa made changes -
          Link This issue blocks CASSANDRA-1397 [ CASSANDRA-1397 ]
          Kelvin Kakugawa made changes -
          Link This issue blocks CASSANDRA-1132 [ CASSANDRA-1132 ]
          Kelvin Kakugawa made changes -
          Link This issue blocks CASSANDRA-1381 [ CASSANDRA-1381 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12451700 ]
          Johan Oskarsson made changes -
          Link This issue is blocked by CASSANDRA-1375 [ CASSANDRA-1375 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12451159 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12449787 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12451159 ]
          Kelvin Kakugawa made changes -
          Attachment Incrementcountersdesigndoc.pdf [ 12450728 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12449787 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447990 ]
          Jeff Hammerbacher made changes -
          Link This issue relates to CASSANDRA-1243 [ CASSANDRA-1243 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447787 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447990 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447344 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447211 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447787 ]
          Kelvin Kakugawa made changes -
          Attachment CASSANDRA-1072-2.patch [ 12447563 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447344 ]
          Johan Oskarsson made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12447211 ]
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12446515 ]
          Johan Oskarsson made changes -
          Summary Incr/decr counters Increment counters
          Description Break out the incr/decr counters out of CASSANDRA-580. Classes are shared between the two features but without the plain version vector code the changeset becomes smaller and more manageable. Break out the increment counters out of CASSANDRA-580. Classes are shared between the two features but without the plain version vector code the changeset becomes smaller and more manageable.
          Johan Oskarsson made changes -
          Attachment CASSANDRA-1072.patch [ 12446515 ]
          Kelvin Kakugawa made changes -
          Field Original Value New Value
          Assignee Kelvin Kakugawa [ kelvin ]
          Johan Oskarsson created issue -

            People

            • Assignee:
              Kelvin Kakugawa
              Reporter:
              Johan Oskarsson
              Reviewer:
              Sylvain Lebresne
            • Votes:
              16 Vote for this issue
              Watchers:
              30 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development