[CASSANDRA-10608] Adding a dynamic column to a compact storage table with the same name as the partition key causes a memtable flush deadlock

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Severity: Low
• Assignee: Mike Adamson
• Reporter: Mike Adamson

Authors

Mike Adamson

Reviewers

Sylvain Lebresne

• Created: 28/Oct/15 11:21
• Updated: 16/Apr/19 09:30
• Resolved: 04/Nov/15 10:42

Description

The reproduction steps for this are as follows:

1. Create the following schema:

   CREATE KEYSPACE ks WITH replication = { 'class': 'SimpleStrategy', 'replication_factor': '1'};
   CREATE TABLE ks.cf (k int, v int, PRIMARY KEY(k)) WITH COMPACT STORAGE;
   

2. Using the thrift client execute the following:

           Column column = new Column(ByteBufferUtil.bytes("k"));
           column.setValue(ByteBufferUtil.bytes(1));
           column.setTimestamp(1);
           client.insert(key, new ColumnParent(compactCf), column, ConsistencyLevel.ONE);
   

This causes an invalid PartitionUpdate to be added to Memtable containing a PartitionColumns containing the partition key ColumnDefinition.

This happens because LegacyLayout.decodeCellName does not check whether the ColumnDefinition is a partition key

Issue Links

• supercedes: CASSANDRA-9910 system_drop_column_family hangs on trunk