Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-10571

ClusteringIndexNamesFilter::shouldInclude is not implemented, SinglePartitionNamesCommand not discarding the sstables it could

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 3.0.0
    • None
    • None
    • Normal

    Description

      Now that we use SinglePartitionNamesCommand in more places - where we'd previously use what is now SinglePartitionSliceCommand - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.

      SinglePartitionNamesCommand::queryMemtableAndDiskInternal should prune sstables based on ClusteringIndexNamesFilter::shouldInclude output, and the latter must be replaced with an actual implementation instead of a TODO.

      This is also a potentially a big regression in performance for counter writes (say, with DTCS), since before 3.0, the read-before-write code would use collectAllData, and that was pruning sstable with non-overlapping clusterings.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            slebresne Sylvain Lebresne Assign to me
            aleksey Aleksey Yeschenko
            Sylvain Lebresne
            Aleksey Yeschenko
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment