[CASSANDRA-10571] ClusteringIndexNamesFilter::shouldInclude is not implemented, SinglePartitionNamesCommand not discarding the sstables it could

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Severity: Normal
• Assignee: Sylvain Lebresne
• Reporter: Aleksey Yeschenko

Authors

Sylvain Lebresne

Reviewers

Aleksey Yeschenko

• Created: 22/Oct/15 17:38
• Updated: 16/Apr/19 09:30
• Resolved: 06/Nov/15 10:55

Description

Now that we use SinglePartitionNamesCommand in more places - where we'd previously use what is now SinglePartitionSliceCommand - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.

SinglePartitionNamesCommand::queryMemtableAndDiskInternal should prune sstables based on ClusteringIndexNamesFilter::shouldInclude output, and the latter must be replaced with an actual implementation instead of a TODO.

This is also a potentially a big regression in performance for counter writes (say, with DTCS), since before 3.0, the read-before-write code would use collectAllData, and that was pruning sstable with non-overlapping clusterings.