Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-10571

ClusteringIndexNamesFilter::shouldInclude is not implemented, SinglePartitionNamesCommand not discarding the sstables it could

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
      None
    • Severity:
      Normal

      Description

      Now that we use SinglePartitionNamesCommand in more places - where we'd previously use what is now SinglePartitionSliceCommand - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.

      SinglePartitionNamesCommand::queryMemtableAndDiskInternal should prune sstables based on ClusteringIndexNamesFilter::shouldInclude output, and the latter must be replaced with an actual implementation instead of a TODO.

      This is also a potentially a big regression in performance for counter writes (say, with DTCS), since before 3.0, the read-before-write code would use collectAllData, and that was pruning sstable with non-overlapping clusterings.

        Attachments

          Activity

            People

            • Assignee:
              slebresne Sylvain Lebresne
              Reporter:
              aleksey Aleksey Yeschenko
              Authors:
              Sylvain Lebresne
              Reviewers:
              Aleksey Yeschenko
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: