[CASSANDRA-10569] Keyspace validation errors are getting lost in system_add_keyspace

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: Legacy/Distributed Metadata
• Severity: Normal
• Assignee: Sam Tunnicliffe
• Reporter: Mike Adamson

Authors

Sam Tunnicliffe

Reviewers

Paulo Motta

• Created: 22/Oct/15 15:49
• Updated: 16/Apr/19 09:30
• Resolved: 27/Oct/15 12:51

Description

The following:

cassandraserver.system_add_keyspace(
    new KsDef("xxx", SimpleStrategy.class.getSimpleName(), 
              Lists.<CfDef>newArrayList()));

used to throw an InvalidRequestException in 2.1.

In 3.0 the strategy validation has been removed from KeyspaceMetadata.validate so the strategy errors don't get picked up until the schema change has been announced. As a result the ConfigurationError is swallowed in FBUtilities.waitOnFuture and thrown on as a RuntimeException.

This possibly affects system_update_keyspace as well.