[CASSANDRA-1054] isSuper flag in cfstore is wrongly set in 0.7

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.7 beta 1
• Severity: Low
• Assignee: Sylvain Lebresne
• Reporter: Sylvain Lebresne

Authors

Sylvain Lebresne

• Created: 05/May/10 19:22
• Updated: 16/Apr/19 09:33
• Resolved: 05/May/10 19:40

Description

In 0.7, following CASSANDRA-16, the isSuper in ColumnFamilyStore is not set correctly (if I'm correct).
This is because when the model is applied (AddColumnFamily.applyModels()) the columnFamilyStore
is created before the call to DataDescriptor.setTableDefinition. But the createColumnFamilyStore()
function retrieve the columnType. This thus always return a null that end up in a "Super".equals(null)
that always sets the flag to false.
That being said, the isSuper flag of columnFamilyStore is never used.
I propose thus to get ride of this flag completely since if needed in the future, the column type can
always be retrieved from the table and cfname directly (the attached patch do just that).