Cassandra
  1. Cassandra
  2. CASSANDRA-1054

isSuper flag in cfstore is wrongly set in 0.7

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Fix Version/s: 0.7 beta 1
    • Component/s: Core
    • Labels:
      None

      Description

      In 0.7, following CASSANDRA-16, the isSuper in ColumnFamilyStore is not set correctly (if I'm correct).
      This is because when the model is applied (AddColumnFamily.applyModels()) the columnFamilyStore
      is created before the call to DataDescriptor.setTableDefinition. But the createColumnFamilyStore()
      function retrieve the columnType. This thus always return a null that end up in a "Super".equals(null)
      that always sets the flag to false.
      That being said, the isSuper flag of columnFamilyStore is never used.
      I propose thus to get ride of this flag completely since if needed in the future, the column type can
      always be retrieved from the table and cfname directly (the attached patch do just that).

        Activity

        Sylvain Lebresne created issue -
        Sylvain Lebresne made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.7 [ 12314533 ]
        Sylvain Lebresne made changes -
        Hide
        Jonathan Ellis added a comment -

        committed, thanks!

        Show
        Jonathan Ellis added a comment - committed, thanks!
        Jonathan Ellis made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12510144 ] patch-available, re-open possible [ 12751140 ]
        Gavin made changes -
        Workflow patch-available, re-open possible [ 12751140 ] reopen-resolved, no closed status, patch-avail, testing [ 12757522 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        34s 1 Sylvain Lebresne 05/May/10 20:23
        Patch Available Patch Available Resolved Resolved
        17m 21s 1 Jonathan Ellis 05/May/10 20:40

          People

          • Assignee:
            Sylvain Lebresne
            Reporter:
            Sylvain Lebresne
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development