[CASSANDRA-10529] Channel.size() is costly, mutually exclusive, and on the critical path

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.0 rc2
• Component/s: Legacy/Local Write-Read Paths
• Severity: Normal
• Assignee: Stefania Alborghetti
• Reporter: Benedict Elliott Smith

Authors

Stefania Alborghetti

Reviewers

Benedict Elliott Smith

• Created: 14/Oct/15 21:36
• Updated: 16/Apr/19 09:30
• Resolved: 16/Oct/15 15:00

Description

stefania_alborghetti mentioned this already on another ticket, but I have lost track of exactly where. While benchmarking it became apparent this was a noticeable bottleneck for small in-memory workloads with few files, especially with RF=1. We should probably fix this soon, since it is trivial to do so, and the call is only to impose an assertion that our requested length is less than the file size. It isn't possible to safely memoize a value anywhere we can guarantee to be able to safely refer to it without some refactoring, so I suggest simply removing the assertion for now.

Issue Links

• is related to: CASSANDRA-10407 Benchmark and evaluate CASSANDRA-8894 improvements
• links to: 3.0 patch