[CAMEL-9954] FormatFactory should be real Factory-pattern

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.18.0
• Component/s: camel-bindy
• Patch Info: Patch Available
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Arno Noordover
• Created: 07/May/16 14:44
• Updated: 22/May/16 06:38
• Resolved: 21/May/16 10:51

Description

The class org.apache.camel.dataformat.bindy.FormatFactory is a utility class which supports a factory-pattern.
According to the factory-pattern this should not be a utility-class but it should be a class that can be instantiated.
This class should implement an interface or extend an abstract class.
Maybe we should make a factory per Format and choose amongst the following solutions:

• let each formatter answer the question about being able to format for certain formating-options (based on type and optionally the pattern for all "numeric" format factories);
• put all formatters in a hashmap with the type as a key.
  With this last solution all the "numeric" format factory should decide which format to return (e.g. BytePatternFormat or ByteFormat based on the pattern being empty or not)

Issue Links

• links to: GitHub Pull Request #990
• links to: GitHub Pull Request #991