[CAMEL-9511] Setting Kafka's endpoint configuration by reference overrides everything instead of merging

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.16.3, 2.17.0
• Component/s: camel-kafka
• Estimated Complexity: Unknown
• Assignee: Akitoshi Yoshida
• Reporter: Serge Smertin
• Created: 13/Jan/16 11:07
• Updated: 04/Feb/16 09:46
• Resolved: 04/Feb/16 09:46

Description

If we set configuration for Kafka endpoint as reference, the actual resulting configuration for endpoint is not merged and some query param-set properties are lost. It's easier to use shared configuration in cases us having global bean with zookeeper configuration and broker list.

    @UriParam
    private KafkaConfiguration configuration = new KafkaConfiguration();

...

    @Override
    protected KafkaEndpoint createEndpoint(String uri,
                                           String remaining,
                                           Map<String, Object> params) throws Exception {

        KafkaEndpoint endpoint = new KafkaEndpoint(uri, this);
        String brokers = remaining.split("\\?")[0];
        if (brokers != null) {
            endpoint.getConfiguration().setBrokers(brokers);
        }
        setProperties(endpoint, params);
        return endpoint;
    }